Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove line limit rule #76

Open
oxinabox opened this issue Sep 30, 2020 · 0 comments
Open

Remove line limit rule #76

oxinabox opened this issue Sep 30, 2020 · 0 comments

Comments

@oxinabox
Copy link
Member

As an alternative to #59
while the whole guide is suggests, we could be more explict about the line limit being a suggestion.

What if we removed the line limit rule, and said instead something a long the lines of:

Lines should be kept to a reasonable length.
In general 92 characters is a reasonable length, but for some things longer (or shorter) may better promote clarity.
For example rather than very long list of function arguments on one line instead ....
or for ternary expressions use if instread, e.g. ...
Conversely, for log messages its often clearer to have a very long string than to split the string up and then concatenate it back together.

Argument for this over #59 is that if you are going to set up to need to deal with really long lines, and thus have your editor either setup to wrap or to horisontal scroll, then once you are setup to do it for string literals it remains setup for other needs.
Counter argument is that strign literals are infact special, and you often don't need to care what is at the other end of the string -- because its almost always a log message or similar, so you only look at enough to workout what it is telling the user.

Just putting this alternative out there for consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant