Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style for (sub)modules? #75

Open
nickrobinson251 opened this issue Sep 28, 2020 · 1 comment
Open

Style for (sub)modules? #75

nickrobinson251 opened this issue Sep 28, 2020 · 1 comment

Comments

@nickrobinson251
Copy link
Contributor

nickrobinson251 commented Sep 28, 2020

e.g. don't indent inside `module ... end"?

# Yes
module Foo

export bar

bar() = 1

end

# No
module Foo

    export bar

    bar() = 1

end

Perhaps other rules? e.g. Blank line after module and before end?

# Yes
module Foo

export bar
bar() = 1

end

# No
module Foo
export bar
bar() = 1
end

it'd also be kind nice to add a comment after end e.g. end # module?

Raised by @iamed2 in iamed2/LibPQ.jl#197 (comment)

@omus
Copy link
Contributor

omus commented Oct 1, 2020

I agree with the suggestions made here. I'd also suggest one module definition per file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants