Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests checking rrules gradients against finite differences #87

Open
BatyLeo opened this issue Jul 19, 2023 · 1 comment
Open

Add tests checking rrules gradients against finite differences #87

BatyLeo opened this issue Jul 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@BatyLeo
Copy link
Member

BatyLeo commented Jul 19, 2023

We should add some tests checking that gradients computed by our rrules are correct.
For this, we can use FiniteDifferences.jl or ChainRulesTestUtils.jl.
@BatyLeo BatyLeo added the enhancement New feature or request label Jul 19, 2023
@gdalle
Copy link
Collaborator

gdalle commented Sep 8, 2023 •
edited

The thing is, our gradients will never be correct cause there are no correct gradients

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gdalle @BatyLeo