Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JET tests #72

Open
gdalle opened this issue Jun 28, 2023 · 8 comments
Open

Fix JET tests #72

gdalle opened this issue Jun 28, 2023 · 8 comments
Labels
bug Something isn't working
Milestone

Comments

@gdalle
Copy link
Collaborator

gdalle commented Jun 28, 2023

Since I figured out how to use JET.report_package properly, it throws a few errors for interface functions that are not implemented. For now the test is skipped, but we need to reactivate it.

@gdalle gdalle added the bug Something isn't working label Jun 28, 2023
@gdalle gdalle added this to the v0.5 milestone Jun 28, 2023
@gdalle
Copy link
Collaborator Author

gdalle commented Jun 29, 2023

@BatyLeo the only JET test failing is linked to the generic imitation loss, care to take a look?
By the way I'm not sure I like the name compute_maximizer there, can we find something a tad more specific?

@BatyLeo
Copy link
Member

BatyLeo commented Jul 4, 2023

When I remove the @test_skip, I do not see any error with ImitationLoss

@gdalle
Copy link
Collaborator Author

gdalle commented Jul 4, 2023

Well then, let's do it and close this issue?

@BatyLeo
Copy link
Member

BatyLeo commented Jul 4, 2023

There are some other errors, one fixed by #84, and one caused by the extension for RegularizedFrankWolfe I'm not sure can be fixed

@gdalle
Copy link
Collaborator Author

gdalle commented Jul 4, 2023

What does the FrankWolfe error look like?

@BatyLeo
Copy link
Member

BatyLeo commented Jul 5, 2023

 ═════ 2 possible errors found ═════
  ┌ (::InferOpt.RegularizedFrankWolfe)(θ::AbstractArray; kwargs::Base.Pairs{Symbol, V, Tuple{Vararg{Symbol, N}}, NamedTuple{names, T}} where {V, N, names, T<:Tuple{Vararg{Any, N}}}) @ InferOpt InferOpt.jl/src/regularized/regularized_frank_wolfe.jl:63
  │ no matching method found `compute_probability_distribution(::InferOpt.RegularizedFrankWolfe, ::AbstractArray)`: @_6 = compute_probability_distribution(regularized::InferOpt.RegularizedFrankWolfe, θ::AbstractArray)
  └────────────────────
  ┌ (::InferOpt.RegularizedFrankWolfe)(θ::AbstractArray; kwargs::Base.Pairs{Symbol, V, Tuple{Vararg{Symbol, N}}, NamedTuple{names, T}} where {V, N, names, T<:Tuple{Vararg{Any, N}}}) @ InferOpt InferOpt.jl/src/regularized/regularized_frank_wolfe.jl:63
  │ no matching method found `kwcall(::NamedTuple{names, T} where {N, names, T<:Tuple{Vararg{Any, N}}}, ::typeof(InferOpt.compute_probability_distribution), ::InferOpt.RegularizedFrankWolfe, ::AbstractArray)`: @_6 = Core.kwcall(merge(Base.NamedTuple()::NamedTuple{(), Tuple{}}, kwargs::Base.Pairs{…})::NamedTuple{names, T} where {N, names, T<:Tuple{Vararg{Any, N}}}, compute_probability_distribution, regularized::InferOpt.RegularizedFrankWolfe, θ::AbstractArray)
  └────────────────────

Methods are not defined (because they are only defined in the extension)

@gdalle
Copy link
Collaborator Author

gdalle commented Jul 5, 2023

I thought loading DifferentiableFrankWolfe before applying JET tests would mean the extension is also loaded

@BatyLeo
Copy link
Member

BatyLeo commented Jul 5, 2023

It does not seem to be the case inside the test_package function. Maybe there is a keyword argument to pass additional packages to load ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants