Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adaptive line search for Frank-Wolfe breaks tests #40

Open
gdalle opened this issue Feb 28, 2023 · 5 comments
Open

Adaptive line search for Frank-Wolfe breaks tests #40

gdalle opened this issue Feb 28, 2023 · 5 comments
Labels
bug Something isn't working
Milestone
v0.7

Comments

@gdalle
Copy link
Collaborator

gdalle commented Feb 28, 2023

Frank-Wolfe related tests fail due to the linear solver for implicit differentiation not converging

Main suspect: ZIB-IOL/FrankWolfe.jl#387
@gdalle gdalle added the bug Something isn't working label Feb 28, 2023
@gdalle
Copy link
Collaborator Author

gdalle commented Feb 28, 2023

Possible solution: #39

@gdalle gdalle mentioned this issue Feb 28, 2023
Merged
BatyLeo added a commit that referenced this issue Mar 28, 2023
@BatyLeo
Merge pull request #39 from axelparmentier/fix_ci
72e54d6 
Clean up tests to diagnose Frank-Wolfe linear solver error:
- Revert specification of test dependencies to the more robust version (see this issue)
- Adjust default parameters for Frank-Wolfe (increase precision and switch step size selection) because a recent release or FrankWolfe.jl broke our tests (see Broken tests #40)
- Deactivate test verbosity to make CI logs easier to read
- Switch data to Float32 to suppress Flux.jl warning
- Try to parallelize tests but they no longer show up in the test set so I gave up (see this discourse thread, it seems like an open problem)
@gdalle
Copy link
Collaborator Author

gdalle commented Apr 13, 2023

We still need to diagnose why this happened in the first place

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 28, 2023

Diagnosis will be easier once #65 is merged. If we switch the line search strategy in the new tests I think the bugs pop up again

@gdalle gdalle changed the title Broken tests Adaptive line search for Frank-Wolfe breaks tests Jun 28, 2023
@gdalle gdalle added this to the v0.5 milestone Jun 28, 2023
@BatyLeo
Copy link
Member

BatyLeo commented Sep 7, 2023

@gdalle the latest FrankWolfe.jl release seems to have broken our RegularizedFrankWolfe tests.
I'm facing the following error locally on main (on paths and ranking tests, argmax seems fine):

 Warning: IterativeLinearSolver failed, result contains NaNs
└ @ ImplicitDifferentiation ~/.julia/packages/ImplicitDifferentiation/HJshL/src/linear_solver.jl:34

@gdalle
Copy link
Collaborator Author

gdalle commented Sep 7, 2023

It may also be due to the latest release of ImplicitDifferentiation. I will take a look

@BatyLeo BatyLeo modified the milestones: v0.6, v0.7 Sep 12, 2023
@gdalle gdalle mentioned this issue Sep 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.7
Development

No branches or pull requests
2 participants
@gdalle @BatyLeo