Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with Julia 1.6 #26

Open
gdalle opened this issue Aug 29, 2022 · 3 comments
Open

Compatibility with Julia 1.6 #26

gdalle opened this issue Aug 29, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.7

Comments

@gdalle
Copy link
Collaborator

gdalle commented Aug 29, 2022

It would be nice to be compatible with Julia's Long Term Support (LTS) version 1.6.
I think the main obstacle at the moment is the use of the destructuring syntax (; a, b) = x, which was introduced in Julia 1.7. Shouldn't be hard to fix, and the test CI needs to be updated too.
@gdalle gdalle added enhancement New feature or request good first issue Good for newcomers labels Aug 29, 2022
@gdalle
Copy link
Collaborator Author

gdalle commented Jun 28, 2023

Use https://github.com/devmotion/SimpleUnPack.jl

@gdalle gdalle changed the title Make compatible with Julia 1.6 Compatibility with Julia 1.6 Jun 28, 2023
@gdalle gdalle added this to the v0.5 milestone Jun 28, 2023
@BatyLeo
Copy link
Member

BatyLeo commented Jun 29, 2023

Is it really useful to be compatible with 1.6 ?

@gdalle
Copy link
Collaborator Author

gdalle commented Jun 29, 2023

Is it really useful to be compatible with 1.6 ?

Debatable. The main reason is that it is the current LTS version, which means some careful companies might only want to use this one for fear of running into issues

@BatyLeo BatyLeo modified the milestones: v0.6, v0.7 Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.7
Development

No branches or pull requests
2 participants
@gdalle @BatyLeo