New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scope is not reset between tests #643
Comments
comhon-project
changed the title
scope is not reset between tests (using laravel)
scope is not reset between tests
Dec 11, 2023
Are you setting the scope in your test code, or are you testing code that sets the scope in userland code? |
@JosephSilber , |
@JosephSilber is there any news about this issue ? |
Changing: protected function registerBouncer()
{
$this->app->singleton(Bouncer::class, function ($app) {
return Bouncer::make()
->withClipboard(new CachedClipboard(new ArrayStore))
->withGate($app->make(Gate::class))
->create();
});
} to: protected function registerBouncer()
{
$this->app->scoped(Bouncer::class, function ($app) {
return Bouncer::make()
->withClipboard(new CachedClipboard(new ArrayStore))
->withGate($app->make(Gate::class))
->create();
});
} in BouncerServiceProvider could fix this issue. Are you able to verify this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello team!
the Scope is persistent between several application initialization (typically during tests).
the scope is defined as a static value in
Silber\Bouncer\Database\Models
and is not reset when bouncer service is initialized.Due to this, the scope is not reset between tests.
I guess it should be reset during
Silber\Bouncer\Bouncer
singleton instantiation.(using Bouncer v1.0.1)
The text was updated successfully, but these errors were encountered: