Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write directly to config file rather than making loopback PUT #1

Open
isaiahtaylor opened this issue Oct 8, 2018 · 0 comments
Open

Comments

@isaiahtaylor
Copy link

When this Node server receives a POST of new settings, it seems like rather than forwarding that as a PUT to the Python server on 8080 through the local loopback, the Node server should just write to the config.json directly. Perhaps once that is done the Python server will need to be notified that the settings have changed, but it would significantly reduce code overhead and make it easier to add new features.

If you're interested, I'd be willing to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant