-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS review: installation #22
Comments
linking openjournals/joss-reviews#3045 |
The XSPEC install works perfectly. However, there are a number of required packages that not installed with either the
can these be added to the requirements so that the examples work out-of-the-box? |
You should not do
done, and release 4.0.3 includes them.
done, modified example_simplest.py
added.
solved in #20 now, available at https://github.com/JohannesBuchner/BXA/tree/master/examples/sherpa as README. |
setup.py is still missing SciPy. Other than that, XSPEC examples run out-of-box on linux |
BXA only requires scipy for some plotting niceties for xspec. However, sometimes scipy is difficult to install on servers, so I do not want to make it a formal requirement in setup.py. I updated the doc to recommend the installation of scipy (here), and mention in the doc which functionality requires scipy (specifically here). Let me know if there are any issues remaining here. |
You mentioned here the MacOS install attempt:
Please try again in a clean environment with:
(This is following https://cxc.cfa.harvard.edu/ciao/download/ciao_install.html) |
closing due to inactivity. Please reopen if this is still an issue. |
Here are the issues with getting into a state of being able to run the
python example_simplest.py
The main required dependency for the fitting,
ultranest
is not installed automatically either by pip or python setup.py installThe setup currently does not run on MacOS.
All of the following is run in a clean virtual environment on Ubuntu 20.04.2 with python 3.8 (no conda)
After completing the install for CIAO with the following steps:
the following steps need to be run to avoid errors:
From this point I try to run
python example_simplest.py
Result:
It would be useful to modify the following:
add all required dependencies to the install/setup script
include examples that work with Sherpa alone as it is the easiest entry point into testing the code.
as BXA is a plugin to the XSPEC/Sherpa analysis software, warning to the user upon installation that the environment does not detect the required essential dependencies to run upon install.
perhaps an end-to-end example in the documentation (including data) would be helpful.
While it is not BXA should not be responsible for upkeep of XSPEC/Sherpa's installation procedures and capabilities, its focus as a plugin to these software means that it needs to perhaps guide the user thru the installation of its core functionality.
In regards to the software not installing on MacOS, this is again an issue of the core packages, but should be reflected in the caveats / platforms listed in the README and documentation. A few of these may be addressed with #21
The text was updated successfully, but these errors were encountered: