Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments rule breaks copyright header #390

Open
vogella opened this issue Jun 14, 2019 · 4 comments
Open

Comments rule breaks copyright header #390

vogella opened this issue Jun 14, 2019 · 4 comments

Comments

@vogella
Copy link
Contributor

vogella commented Jun 14, 2019

I have the following

/*******************************************************************************
 * Copyright (c) 2005, 2015 IBM Corporation and others.
 *
 * This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License 2.0
 * which accompanies this distribution, and is available at
 * https://www.eclipse.org/legal/epl-2.0/
 *
 * SPDX-License-Identifier: EPL-2.0
 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 ******************************************************************************/

If I run the Comments refactoring I get the following

/**
 * Copyright (c) 2005, 2015 IBM Corporation and others.
 *
 * This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License 2.0
 * which accompanies this distribution, and is available at
 * https://www.eclipse.org/legal/epl-2.0/
 *
 * SPDX-License-Identifier: EPL-2.0
 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 */

Would be nice if the copyrright header could remain unchanged.

@Fabrice-TIERCELIN
Copy link
Collaborator

I admit, it's not my favorite rule :) Actually, I disable it :) If I had to migrate the rules, I would leave this one behind.

@vogella
Copy link
Contributor Author

vogella commented Jun 15, 2019

Bye the way, is there page which describes the implemented rules? I have to admit that I did not yet look at the code but I did not see an explanation on the project page nor in the installed tool. Maybe I did not look enough...

@Fabrice-TIERCELIN
Copy link
Collaborator

I think the best available description is the comparison before/after from the test samples:
http://autorefactor.org/html/samples.html (CommentsSample.java)

@vogella
Copy link
Contributor Author

vogella commented Jun 16, 2019

Thanks @Fabrice-TIERCELIN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants