Complete Current Statement on Enter breaks Rename

[chylex]

Hi. I have the following binding:

nmap <Enter> :action EditorCompleteStatement<CR>

However, if I use the Rename refactoring and for ex. delete a character in normal mode, then pressing Enter runs the action before the Rename finishes, which discards all the changes I made while renaming.

Is there a way to ensure the mapping does not run while renaming an element? Thanks.

[AlexPl292]

Hi, that's an interesting case. Actually, I think it's possible using the vim script, so you could create some function like

function! EnterFunction()
  if (renaming)
    <Enter>
  else
    :action EditorCompleteStatement<CR>
  endif
endfunction

nmap <expr> <Enter> EnterFunction()

However, at the moment this is not possible to verify if the renaming is in progress. We'll discuss the possibility of adding such function.

[chylex]

There might be a better solution for this specific use case, such as not allowing IdeaVIM to take over Enter (or the configured IDEA keybinding for accepting the change) when a refactoring action is in progress. Is there any use case where someone might legitimately want IdeaVIM to interfere with the keybinding that confirms a refactoring?

[chylex]

I implemented this solution in my fork, it seems to make the original mapping nmap <Enter> :action EditorCompleteStatement<CR> work well: chylex@080dbe9

(edited, found a bug)

[chylex]

I've been using the solution in chylex@080dbe9 for a while now without noticing any issues. Would you accept a PR for it?

[AlexPl292]

Hi there! We now have a bit of an unstable state around enters and escapes. We migrated to a different way of handling them, but it slowly turned out that the previous one seemed to be the correct one. So, I'd like to stabilize things before doing further changes around key processing.

BTW, with the latest version of IdeaVim, your described case works for me without any fixes. However, as there is a chance that we'll get back to the previous solution, this problem may arise again.
I've created a ticket and I'll add it to the scope of the enter key questions. So, we'll create a UI test for it, and I'll check if works with the different implementations of key processing. If the issue exists, let's discuss your solution.

VIM-3254