Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaders not working for the focused screen in Hybrid layouts #169

Open
5 of 11 tasks
jklphe00 opened this issue Feb 14, 2024 · 4 comments
Open
5 of 11 tasks

Shaders not working for the focused screen in Hybrid layouts #169

jklphe00 opened this issue Feb 14, 2024 · 4 comments
Labels
bug Something isn't working screen layouts For issues involving the position of the emulated console's screens.

Comments

@jklphe00
Copy link

jklphe00 commented Feb 14, 2024

What version of melonDS DS are you using?

1.1.0 and 1.0.3

Does the problem happen in standalone melonDS?

I don't know.

What happened?

When using shaders, only the smaller screens in Hybrid layouts have the shaders applied; the focused bigger screen remains unaffected. This happens whether the small screen mode is set to opposite screen or both screens and it happens whether the top or bottom screens are focused. Other layouts appear to be fine; this issue only occurs with Hybrid layouts.

See attached pics. Here I used the scalefx-aa-fast.slangp preset as my shader. Tested with melonDS DS v1.0.3 and v1.1.0. Render mode used is Software.

Pokemon - HeartGold Version (USA)-240214-000406
Pokemon - HeartGold Version (USA)-240214-000419
Pokemon - HeartGold Version (USA)-240214-000529
Pokemon - HeartGold Version (USA)-240214-000559

What should've happened instead?

All screens should have had the shaders applied.

Which platforms do you see the problem on?

  • Windows
  • macOS
  • Linux
  • Android
  • iOS
  • tvOS
  • Other (specify below)

Which versions of the OS?

Windows 10

Which libretro frontend are you using?

RetroArch 1.17.0, Steam version

Terms

  • I agree to follow the code of conduct.
  • I understand that melonDS DS is not developed or maintained by the authors of melonDS.
  • I understand that this form is for reporting bugs, not for requesting help.
  • I understand that the author develops this core in his spare time, and that he is under no obligation to respond to this bug report.
@jklphe00 jklphe00 added the bug Something isn't working label Feb 14, 2024
@JesseTG
Copy link
Owner

JesseTG commented Feb 15, 2024

I notice the rounded corners in the focused screen, although it's more subtle. It seems to me that these shaders are being applied, or is there something I'm not understanding?

@JesseTG JesseTG added the screen layouts For issues involving the position of the emulated console's screens. label Feb 15, 2024
@jklphe00
Copy link
Author

jklphe00 commented Feb 16, 2024

Sorry. Yes, I do believe there is a misunderstanding here. The intention of the shader scalefx-aa-fast is to smooth out the pixelated look. Here's a screenshot of what the intended look is in the Left/Right layout:

Pokemon - HeartGold Version (USA)-240215-154641

Now, compared to the Hybrid layout:

Pokemon - HeartGold Version (USA)-240215-154929

So, although the focused screen does seem to have some subtle rounded corners, it appears that the shaders are applied incorrectly to just that screen. If I had to guess, maybe the shader is being applied once to the entire layout when it should be applied separately to the focused screen and the smaller screens due to different resolutions/pixel densities of the different screen sizes? I don't truly know, but that is my guess into what is happening since the smaller screens in hybrid mode have the shader appearing as intended.

Edit: Just a quick note. I also tested the xbrz-freescale shader with the same outcome.

@jklphe00 jklphe00 reopened this Feb 16, 2024
@jklphe00
Copy link
Author

jklphe00 commented Feb 16, 2024

(Please ignore me closing and reopening this issue. I clicked the wrong thing.)

@JesseTG
Copy link
Owner

JesseTG commented Feb 16, 2024

Ah, thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working screen layouts For issues involving the position of the emulated console's screens.
Projects
None yet
Development

No branches or pull requests

2 participants