Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keywords not replaced #134

Open
karmendra opened this issue Jan 23, 2021 · 2 comments
Open

Keywords not replaced #134

karmendra opened this issue Jan 23, 2021 · 2 comments

Comments

@karmendra
Copy link

Laravel 8.24
PHP 7.4.10
Homestead 9 (vagrant up via an admin cmd in windows 10)

After the package version 2.6 is installed and when I try to create a new package using new command as following
php artisan packager:new vend pack

package is created in packages directory but the following keywords are not replaced.

':uc:vendor',
':uc:package',
':lc:vendor',
':lc:package',

Following screenshot show how generated Facade class looks like.
image

Even the file names are not changed. Facade file is coming as
packages/vend/pack/src/Facades/MyPackage.php

@kodyxgen
Copy link

It's not the best workaround but try adding a sleep(5) Commands/newPackage.php line 105 before manifest = ...
This helped me create the package with success.

@karmendra
Copy link
Author

After I update to the latest version i.e. 2.7 , and then attempted to create the package, this time it did replace the keywords, but it didn't rename the files.

I tried the trick that @kodyxgen share above, and this time it did properly rename the file names as well. @kodyxgen Thanks for this tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants