Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for deriveing Borrow #260

Open
damooo opened this issue May 15, 2023 · 2 comments · May be fixed by #145
Open

Support for deriveing Borrow #260

damooo opened this issue May 15, 2023 · 2 comments · May be fixed by #145
Labels
enhancement help wanted new derive

Comments

@damooo
Copy link

damooo commented May 15, 2023

Hello, it would be helpful if deriving an implementation of std::borrow::Borrow is supported.
@tyranron tyranron linked a pull request May 22, 2023 that will close this issue
Add Borrow and BorrowMut derives #145
Open
@tyranron
Copy link
Collaborator

@damooo hi, we do have #145 implementing this. However, it's somewhat postponed until we go into 1.0 release.

@damooo damooo closed this as completed May 25, 2023
@tyranron tyranron reopened this May 26, 2023
@JelteF
Copy link
Owner

JelteF commented Dec 18, 2023

#145 does implement it, but the implementor didn't need it anymore so the PR seems abandoned. I don't think many changes are needed to get it over the finish line though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted new derive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Borrow and BorrowMut derives Slabity/derive_more
3 participants
@JelteF @tyranron @damooo