Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Updating Extensions Hangs, no Trust Prompt presented to user until restart. #1734

Open
8 of 9 tasks
jedinjapan opened this issue Jan 22, 2024 · 1 comment · May be fixed by #1766
Open
8 of 9 tasks

[Bug] Updating Extensions Hangs, no Trust Prompt presented to user until restart. #1734

jedinjapan opened this issue Jan 22, 2024 · 1 comment · May be fixed by #1766
Labels
bug Something isn't working

Comments

@jedinjapan
Copy link

Steps to reproduce

  1. User has extensions installed.
  2. Extension detects an update from a new repo.
  3. Update > Install > nothing.

App must be closed and reopened for the "Trust" prompt to appear when you scroll through them on sources

Expected behavior

Update > Install > Trust Check > Trust Prompt > Install Finished > Extension is useable

If there is an issue with repo changing causing a trust issue, the app should prompt the user after install immediately to trust, or assume trust from the install prompt being approved manually. Alternatively, trust could be managed at a per-repo level, and updates from the same source not incur this check.

Actual behavior

Update > Install > Install Completes > Nothing

Extension still appears prompting to update, user can begin a second install which will hang, but cannot proceed to trust the extension until restarting the app, where any pending trust prompts will show all at once.

Crash logs

No response

TachiyomiJ2K version

1.7.4

Android version

Android 14

Device

Google Pixel 7

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • If this is an issue with an extension, I should be opening an issue in the extensions repository.
  • I am reporting an issue exclusive to this fork. I have also checked that is not an issue on the main version of Tachiyomi
  • I have tried the troubleshooting guide.
  • I have updated the app to version 1.7.4.
  • I have updated all installed extensions.
  • I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
  • I have filled out all of the requested information in this form.
@jedinjapan jedinjapan added the bug Something isn't working label Jan 22, 2024
@Ekidoxx Ekidoxx mentioned this issue Jan 23, 2024
Open
9 tasks
@AdamHavlicek
Copy link

AdamHavlicek commented Feb 1, 2024 •
edited

@jedinjapan I came up with this fix and it might be a solution for this bug.

tachiyomiJ2K/app/src/main/java/eu/kanade/tachiyomi/extension/ExtensionManager.kt

Line 410 in 8946395

override fun onExtensionUntrusted(extension: Extension.Untrusted) { 

  override fun onExtensionUntrusted(extension: Extension.Untrusted) {
            val installedExtension = _installedExtensionsFlow.value
                .find { it.pkgName == extension.pkgName }
            if (installedExtension != null) {
                _installedExtensionsFlow.value -= installedExtension
            }
            _untrustedExtensionsFlow.value += extension
        }

AdamHavlicek added a commit to AdamHavlicek/tachiyomiJ2K that referenced this issue Feb 3, 2024
@AdamHavlicek
fix(extensions): Add extension to untrusted extension flow after inst…
91c378d 
…allation Jays2Kings#1734
@AdamHavlicek AdamHavlicek linked a pull request Feb 3, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(extensions): Add extension to untrusted extension flow after inst… AdamHavlicek/tachiyomiJ2K
2 participants
@jedinjapan @AdamHavlicek