Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: Check shapes in integrator. #377

Open
daniel-dodd opened this issue Aug 30, 2023 · 0 comments
Open

dev: Check shapes in integrator. #377

daniel-dodd opened this issue Aug 30, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@daniel-dodd
Copy link
Member

Thankfully beartype told me there was an issue with my code during refactoring to CoLA #370, but we need to be really careful with shapes in the integrator for quadrature.

If we pass the wrong shapes through, we get the wrong answer.

We should include a shape check here!
@daniel-dodd daniel-dodd added the enhancement New feature or request label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daniel-dodd