Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing system audio output device requires code-radio restart #7

Open
shnewto opened this issue Jan 1, 2023 · 4 comments
Open

changing system audio output device requires code-radio restart #7

shnewto opened this issue Jan 1, 2023 · 4 comments

Comments

@shnewto
Copy link
Contributor

shnewto commented Jan 1, 2023

Hello! I love this crate! thanks for putting it together 馃槃

I noticed that when code-radio is playing in my terminal (macOS 13.0.1, Intel, iTerm2 Build 3.4.18), if I switch my audio output device, code-radio doesn't play there unless I quit and restart. So for instance, if I'm listening on my laptop speakers then plug in headphones, I have to restart code-radio to get in in the headphones.

By no means is this a big deal for me, it's simple to just restart, but I thought I'd raise the issue in case it's not on the radar.

@JasonWei512
Copy link
Owner

JasonWei512 commented Jan 2, 2023

It's a known issue and the default behavior of rodio and cpal. I am facing the same issue on my Windows laptop.
I am also looking for a workaround. Will look into it when I have time.

Some related issues:

@shnewto
Copy link
Contributor Author

shnewto commented Jan 2, 2023

ah sounds great, thanks for the pointers!

JasonWei512 pushed a commit that referenced this issue Jan 3, 2023
Respect macOS output device selection
@JasonWei512
Copy link
Owner

JasonWei512 commented Jan 3, 2023

Thanks for #9! I have released 1.0.2 to crates.io.

However the problem still exists on Windows. Looks like cpal implemented the audio device switching logic for macOS but not for Windows.

Could you keep this issue open?


Update:

RustAudio/rodio#463

RustAudio/cpal#740

@shnewto
Copy link
Contributor Author

shnewto commented Jan 3, 2023

ohh yeah if it's still the case for windows keeping this open makes good sense. thanks for the new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants