Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Login to transfermarkt #254

Open
robjbrain opened this issue Feb 7, 2023 · 2 comments
Open

Feature: Login to transfermarkt #254

robjbrain opened this issue Feb 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@robjbrain
Copy link

Is it possible to add the ability to login to Transfer Market? There is some useful information available when you view the form to edit a club or person that isn't available on their profile page e.g: https://www.transfermarkt.co.uk/manchester-united/korrektur/verein/985

image

image

@JaseZiv
Copy link
Owner

JaseZiv commented Feb 9, 2023

Thanks for submitting this feature request.

We won't do this for now - to get this to work would require a fair bit of architecting and potentially adding more bloat to the library's installation, and the additional information probably doesn't warrant the extra work.

If you were really keen on the idea, you could always build a POC and create a PR for review? Totally up to you though as it may be a bit of work and might still not get integrated?

Thanks again

@robjbrain
Copy link
Author

No worries, i'll look into it but might be beyond my skill level

@tonyelhabr tonyelhabr added the enhancement New feature or request label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants