Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fb_team_player_stats breaks when fbref adds players with no associated link #123

Open
francescozonaro opened this issue May 22, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@francescozonaro
Copy link
Contributor

francescozonaro commented May 22, 2022

Hi, just an heads up, was using the fb_team_player_stats function and noticed it is now broken

playerList = data.frame(fb_team_player_stats(squad_urls, stat_type = 'standard'))
[======================>---------------------------------------------------------------------------------------------] 20%Error in dplyr::mutate():
! Problem while computing PlayerURL = player_urls.
x PlayerURL must be size 41 or 1, not 40.
Run rlang::last_error() to see where the error occurred.

The problem is that

image

FBRef added a player in juventus squad list which has no associated link (at least for now). The function expects a number of links = to the number of players and breaks.

It's not a big problem tbh because I suppose FBRef will quickly add at least some sort of mockup page for the guy (I'm surprised they just plainly added a row to the table honestly)

Edit: Player link has already been added, but will leave it here in case you still would like to know

@JaseZiv
Copy link
Owner

JaseZiv commented May 23, 2022

Thanks for submitting this.

I will look to get this sorted asap.

Will keep you posted.

Thanks again!

@JaseZiv
Copy link
Owner

JaseZiv commented Jun 4, 2022

Will keep this open until I find another example of this breaking.

@JaseZiv JaseZiv added the bug Something isn't working label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants