Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agama): use a mixed strategy for serialization #6834

Closed
jgomer2001 opened this issue Nov 29, 2023 · 0 comments · Fixed by #6883
Closed

feat(agama): use a mixed strategy for serialization #6834

jgomer2001 opened this issue Nov 29, 2023 · 0 comments · Fixed by #6883
Assignees
@jgomer2001
Labels
comp-agama Touching folder /agama kind-feature Issue or PR is a new feature request
Milestone
1.0.21

Comments

@jgomer2001
Copy link
Contributor

jgomer2001 commented Nov 29, 2023 •
edited

There is not a definite fix for issue #6528

A way to mitigate the problem is using a combination of Java and kryo serialization based on some heuristics, for instance:

a) Exceptions should be serialized with Java. kryo should not be used here according to my personal experience. Also this comment
b) Objects belonging to packages java.*, sun.*, com.sun.*, jdk.* should be serialized with Java
c) use kryo in other cases

Behaviors in b and c should be parameterized. As such, we can replace property serializerType in the agama configuration with the specific policies

In all cases, when serialization of a Java object is about to occur, we have to log the class and the type of serializer attempted - this helps troubleshooting in case the process fails

This overhaul requires some amount of doc updates too
@jgomer2001 jgomer2001 self-assigned this Nov 29, 2023
@jgomer2001 jgomer2001 mentioned this issue Nov 29, 2023
Closed
@mo-auto mo-auto added comp-agama Touching folder /agama kind-feature Issue or PR is a new feature request labels Nov 29, 2023
@moabu moabu added this to the 1.0.21 milestone Nov 30, 2023
jgomer2001 added a commit that referenced this issue Dec 1, 2023
@jgomer2001
chore: misc enhancements #6834
71004df
jgomer2001 added a commit that referenced this issue Dec 1, 2023
@jgomer2001
feat: implement a mixed strategy for serialization of state #6834
2006c48
jgomer2001 added a commit that referenced this issue Dec 1, 2023
@jgomer2001
feat: update configuration for #6834
d4e0e67
jgomer2001 added a commit that referenced this issue Dec 1, 2023
@jgomer2001
docs: update docs in accordance to new serialization behavior #6834
f364e10
@jgomer2001 jgomer2001 mentioned this issue Dec 1, 2023
Merged
5 tasks
yuriyz pushed a commit that referenced this issue Dec 1, 2023
@jgomer2001
feat(agama): use a mixed strategy for serialization (#6883)
00aee0c 
* chore: misc enhancements #6834

* feat: implement a mixed strategy for serialization of state #6834

* feat: update configuration for #6834

* docs: update docs in accordance to new serialization behavior #6834
devrimyatar pushed a commit that referenced this issue Dec 7, 2023
@jgomer2001 @devrimyatar
feat(agama): use a mixed strategy for serialization (#6883)
fa85487 
* chore: misc enhancements #6834

* feat: implement a mixed strategy for serialization of state #6834

* feat: update configuration for #6834

* docs: update docs in accordance to new serialization behavior #6834

Signed-off-by: Mustafa Baser <mbaser@mail.com>
devrimyatar pushed a commit that referenced this issue Dec 30, 2023
@jgomer2001 @devrimyatar
feat(agama): use a mixed strategy for serialization (#6883)
ce979d2 
* chore: misc enhancements #6834

* feat: implement a mixed strategy for serialization of state #6834

* feat: update configuration for #6834

* docs: update docs in accordance to new serialization behavior #6834

Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgomer2001 jgomer2001

Labels
comp-agama Touching folder /agama kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
1.0.21
Development

Successfully merging a pull request may close this issue.

feat(agama): use a mixed strategy for serialization JanssenProject/jans
3 participants
@jgomer2001 @moabu @mo-auto