-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): sync @type/xxx
packages
#138
Comments
Thanks @kevinxh, it's a good idea. The closest thing today is https://jamiemason.github.io/syncpack/config/version-groups/pinned#pinversion-string but that's quite manual. I'll have a think how best to do this, some kind of aliasing feature or something. |
Opening this up to people for ideas on a nice way to handle this
|
I'm new to syncpack. I got here trying to figure out why this didn't work:
So maybe similar syntax since that's how it reads. |
I think I see what you're trying to do there @mctrafik, I think this is close to the {
"label": "Ensure react is all same version",
"packages": ["**"],
"dependencies": ["react", "react-dom", "@types/react", "@types/react-dom"],
"dependencyTypes": ["!peer"],
"pinVersion": "18.2.0"
} I don't think this quite works in this scenario though as EDIT: I wonder if an approach something like this would work, so those packages are treated as being one. {
"label": "Ensure react is all same version",
"packages": ["**"],
- "dependencies": ["react", "react-dom", "@types/react", "@types/react-dom"],
+ "aliases": ["react", "react-dom", "@types/react", "@types/react-dom"],
"dependencyTypes": ["!peer"],
"pinVersion": "18.2.0"
} |
Dropping some $0.02 worth of context here. The way It's not exactly SemVer, but SemVer-ish. Also, one caveat/edge case, is that the version of the So all of these heuristics would need to be encoded in the logic. |
@type/xxx
packages@type/xxx
packages
Description
It would be nice if syncpack could sync the
@type/xxx
typescript declaration packages.For example, we use
syncpack fix-mismatches
and upgrade one of our depsjsonwebtoken
, but the types package@types/jsonwebtoken
is left at older version.Suggested Solution
Help Needed
The text was updated successfully, but these errors were encountered: