Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to re-enable user comments #11021

Open
ror3d opened this issue Mar 13, 2024 · 25 comments
Open

Make it easier to re-enable user comments #11021

ror3d opened this issue Mar 13, 2024 · 25 comments
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@ror3d
Copy link
Contributor

ror3d commented Mar 13, 2024

Is your suggestion for improvement related to a problem? Please describe.
When viewing the comments for an entry in the Comments tab, there are both "general" comments and user comments, and when user comments are visible, there is a button below prompting "Hide user comments". If that is clicked, the only way to re-enable user comments is through the settings. It is easy to misclick on, and a pain to have to re-enable when that happens.

Describe the solution you'd like
It would be nice for a similar button to be available in the same Comments tab to show the user comments back more easily.

Additional context

image
image
image

@koppor
Copy link
Member

koppor commented Mar 14, 2024

We are on the same page: #10424 (comment)

Other maintainers thought differently: #10610 (comment)

Not sure how to proceed. That kind of button is the only one of that kind in JabRef. Maybe more a global library setting: #10610 (comment)

@koppor
Copy link
Member

koppor commented Mar 14, 2024

Maybe another Preference: "Disable button to hide user- specific comments"? 😅

@ror3d
Copy link
Contributor Author

ror3d commented Mar 14, 2024

What I would suggest:
image
image

This would stay out of the way (leaving more space, as mentioned in #10424) and allow for enabling/disabling showing them in the same interface.

The buttons might be changed for icons instead maybe
image

but thats secondary I think.

@koppor koppor added ui good first issue An issue intended for project-newcomers. Varies in difficulty. labels Mar 14, 2024
@koppor
Copy link
Member

koppor commented Mar 14, 2024

@ror3d Thank you for your UI sketches. This way, this issue becomes a "good first issue" which can be handled by students.

@Realmbird
Copy link

Can I take this issue

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Mar 15, 2024
@Realmbird
Copy link

Realmbird commented Mar 17, 2024

setting up gitter is there an iPhone app for it? I see gitter lite and it looks different from gitter on computer

@Siedlerchr
Copy link
Member

@Realmbird yo should be able to use any matrix client I guess https://app.gitter.im/#/room/#JabRef_jabref:gitter.im

@Realmbird
Copy link

Realmbird commented Mar 19, 2024

currently getting student developer for github for ide, got accepted just waiting for benefits

@koppor
Copy link
Member

koppor commented Mar 19, 2024

I think the Community edition of IntellIj works well, too. Just try!

@Realmbird
Copy link

Ok

@Realmbird
Copy link

Realmbird commented Mar 21, 2024

Finally got environment setup, took me time since I am open source beginner. Now I am gonna try fixing problem

@Realmbird
Copy link

Realmbird commented Mar 21, 2024

@koppor @ror3d I have a question I understand I my idea of a solution is to have a show user comment button in the comment tab where the hide user comments. Also how do I get entries to check the comments for since after running JabRef I see no entries.

@Realmbird
Copy link

Screenshot from 2024-03-20 17-23-45

@Realmbird
Copy link

Screenshot from 2024-03-20 17-28-17
How does the page code work with java I tried git grep for hide user comments and not sure how the pages load with java

@Siedlerchr
Copy link
Member

You need to create a new library and add entries or open an existing one

@koppor
Copy link
Member

koppor commented Mar 21, 2024

Maybe the user documentation of JabRef helps to understand the tool usage? Check https://docs.jabref.org/collect/add-entry-manually for instance.

@Realmbird
Copy link

Thanks

@koppor
Copy link
Member

koppor commented Mar 24, 2024

The existing functionality is described at https://docs.jabref.org/finding-sorting-and-cleaning-entries/comment-on-an-entry.

This issue about to move the "Hide user comments" button. In case user comments are hidden, a new button "Show user comments" should be displayed. The UI sketch is given at #11021 (comment).

@Realmbird
Copy link

I think I got it to work gonna send pull request

@Realmbird
Copy link

@koppor Check pull request #11090

@koppor
Copy link
Member

koppor commented Mar 26, 2024

@Realmbird no need to ping at the issue, we see the pull requests. In case the PR is poperly linking the issue (which the concrete PR does), the link from the issue to the PR is established. -- I hope, your GitHub notifications work so that you saw our review comments?

@Realmbird
Copy link

Unassign me

@koppor
Copy link
Member

koppor commented Apr 15, 2024

Unassign me

@Realmbird OK. You should have been able to unassign yourself.

@koppor koppor removed the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Apr 15, 2024
@JabRef JabRef deleted a comment from github-actions bot Apr 15, 2024
@koppor
Copy link
Member

koppor commented Apr 15, 2024

Additional refined requirements:


We should be more precise here:

1. Rename "Show user comments field" to "Show user-specific comments field" (keep "s" at the end at "comments")

image

Reasons:

  1. It is only about the comment field of the current user, not any other user
  2. It is the field specific for ("tied to") the user - not the general "comment" field

2. Rename "Hide user comments" to "Hide user-specific comments field"

image

Reasons: Same as for 1.

3. Rename "Show user comments" to "Show user-specific comments field"

image

Reasons: Same as above

4. Do NEITHER show "Show user-specific comments field" nor "Hide user-specific comments field" if user-specific comment already shown

Example for user "koppor"

image

image

Code hint: #11090 (comment)

@sirine707
Copy link

is this issue still available to work on , if yes please assign me .

@koppor koppor added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Apr 23, 2024
@koppor koppor removed the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label May 16, 2024
@JabRef JabRef deleted a comment from github-actions bot May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Status: Free to take
Status: Free to take
Status: Low priority
5 participants