Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

schedula and formulas recipes #5

Open
vinci1it2000 opened this issue Oct 15, 2019 · 10 comments
Open

schedula and formulas recipes #5

vinci1it2000 opened this issue Oct 15, 2019 · 10 comments
Assignees
Labels
question Further information is requested

Comments

@vinci1it2000
Copy link
Member

Why did you add the recipes for schedula and formulas? They are already in conda-forge (schedula and formulas). Moreover, formulas is not used in co2mpas (see setup.py).

@vinci1it2000 vinci1it2000 added the question Further information is requested label Oct 15, 2019
@ankostis
Copy link
Member

Wen i started building thr EXE back in May, these were not merged in conda-feedstock.

I remember formulas were used to populate the formulas of the output-excel file, eg this version.
Where is this dependency now?

@vinci1it2000
Copy link
Member Author

vinci1it2000 commented Oct 15, 2019

It is not needed anymore. I think that you can remove both recipes, conda-forge is automatically updating the library versions. Am I right?

@ankostis
Copy link
Member

yes, lib=versions are bumped automatically by conda feedstock on eachnew PyPi release.

What about formulas?
They must be somwhere in our deps, no?

@ankostis
Copy link
Member

I mean, don't we do the trick with excel-formulas anymore?

@vinci1it2000
Copy link
Member Author

No. As I said before, we don’t need anymore.

@ankostis
Copy link
Member

I'm curious now.

When and why we don't need?
From your commit-message i cannot see why the dependency has been dropped
Can you pleas be more descriptive?

@vinci1it2000
Copy link
Member Author

The commit is this: https://github.com/JRCSTU/co2mpas/commit/5a177857ffce3490eb84658782872eb093ee29d6.

The reason is that co2mpas_dice doesn't read the excel output file, and the dice report is created directly for the code.

@ankostis
Copy link
Member

That's exactly the commit i had in mind - no reason at all is given why the changes took place.

In general, commits involving dependencies must document very well the "why?".

@stefano you have also to remove formulas from co2mpas, and do a cross check, along with the pending #4.

@vinci1it2000
Copy link
Member Author

@ankostis you don't remember, but I said several times (to you and during the meetings). We planned a huge refactoring dropping unneeded dependencies, for this reason, co2mpas has a new version 4.x. Anyhow, it has been documented in the minutes of meetings. Moreover, there are two issues opened for that https://github.com/JRCSTU/co2mpas/issues/506 and https://github.com/JRCSTU/co2mpas/issues/408.

If for you this is not enough, you may ask to @spycon69 a more detailed report.

@ankostis
Copy link
Member

I don't understand. None of the linked issues mention anything about formulas being dropped, ami i missing something?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants