Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binance.Net.Objects.Models.Futures.BinanceFuturesOrder Incorrect json map #1334

Open
XHighIntell opened this issue Dec 28, 2023 · 5 comments

Comments

@XHighIntell
Copy link

Describe the bug

  1. Places an new limit order at future (quantity = 0.004), wait for order to be FILLED
  2. Get order by using UsdFuturesApi.Trading.GetOrderAsync(symbol, orderId)
  3. Result is QuantityFilled is zero

image

Here is raw response from /fapi/v1/order?symbol=BTCUSDT&orderid=123
image

image

You maped cumQty to QuantityFilled. cumQty does not exist in response.
You maped executedQty to LastFilledQuantity that should be QuantityFilled

@XHighIntell XHighIntell changed the title Binance.Net.Objects.Models.Futures.BinanceFuturesOrder BUG Binance.Net.Objects.Models.Futures.BinanceFuturesOrder Incorrect json map Dec 28, 2023
@dante1989
Copy link

Thank you. How about Coin-m Future? the same problem?

@XHighIntell
Copy link
Author

@dante1989 I don't use Coin-M Future, I can't send real request right now.

Look at the document, Coin-M Future has some fields that are different.
https://binance-docs.github.io/apidocs/delivery/en/#query-order-user_data

Looks like cumQty does not exist either.
So Yes, the same problem for QuantityFilled

@JKorf
Copy link
Owner

JKorf commented Jan 4, 2024

Hm seems to mapped incorrectly yes. Not sure where that originates from. I'll have a look

@JKorf
Copy link
Owner

JKorf commented Jan 5, 2024

I've corrected the model(s), should be working correct now. Let me know if you have any issues

@dante1989
Copy link

dante1989 commented Jan 10, 2024

For Example:
Dim ItemOrderBinance_USD As WebCallResult(Of BinanceUsdFuturesOrder)
ItemOrderBinance_USD = Await clientFutureBinance.UsdFuturesApi.Trading.GetOrderAsync(Symbol, , ClientOrderId)

How could I make new ItemOrderBinance (class BinanceFuturesOrder) by converting from Class BinanceUsdFuturesOrder or copying the same properties from BinanceUsdFuturesOrder.
For me, I like to combine BinanceUsdFuturesOrder and BinanceFuturesOrder Like Old Version (Version 9.3.0 - 26 Dec 2023) because I write a bot for USD future and Coin Future all in 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants