Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Load icons from backup #3177

Open
3 tasks done
biagio11 opened this issue Apr 30, 2024 · 7 comments
Open
3 tasks done

[FEATURE] Load icons from backup #3177

biagio11 opened this issue Apr 30, 2024 · 7 comments
Labels
approved Approved by the Ivy Wallet team. Ready for dev bug Something isn't working user request Feature/improvement requested by an user

Comments

@biagio11
Copy link
Contributor

biagio11 commented Apr 30, 2024

Please confirm the following:

  • I've checked the current issues for duplicate issues.
  • I've requested a single (only one) feature/change in this issue. It complies with the One Request Per GitHub Issue (ORPGI) rule.
  • My issue is well-defined and describes how it should be implemented from UI/UX perspective.

What do you want to be added or improved?

If all the data is lost, removed from the device, or migrated to a new device, I would like the category icons to load and show correctly when loading the data. As for now when loading data from backup from scratch it shows the default icon "category" for the categories and the "account" for the accounts.

I looked into the .json file and I can see that the categories are saved with an "icon" label so it should be an easy fix.

Why do you need it?

  • To have a better user experience if files are lost or device gets changed.

How do you imagine it?

Simply load and show the user the correct icons once the data is loaded from backup from scratch.

@biagio11 biagio11 added the user request Feature/improvement requested by an user label Apr 30, 2024
@biagio11 biagio11 changed the title [FEATURE] Load category icons from backup [FEATURE] Load icons from backup Apr 30, 2024
@ivywallet
Copy link

Thank you @biagio11 for raising Issue #3177! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

@ILIYANGERMANOV
Copy link
Collaborator

Hey @biagio11 did you try "Backup Data" and not CSV. I think the JSON backup preserves the icons?

@ILIYANGERMANOV
Copy link
Collaborator

Can you attach a demo video where you repro this bug?

@biagio11
Copy link
Contributor Author

biagio11 commented Apr 30, 2024

I imported from the actual Ivy Wallet backup.

I can try to understand and find the issue in the code.
I suspect it is related to the data quantity (performance issue?) as with a small test case it seems like it won't happend.

If the behaviour is not expected we should consider it a minor bug.

I'll keep you updated!

@ILIYANGERMANOV ILIYANGERMANOV added bug Something isn't working approved Approved by the Ivy Wallet team. Ready for dev labels May 1, 2024
@biagio11
Copy link
Contributor Author

biagio11 commented May 1, 2024

Unfortunately, I'm unable to replicate the issue consistently.
When I try so, sometimes only a few categories display with the "category" icon, while at other times they show correctly. Occasionally, none of the categories appear at all.

During my tests, I noticed that the app occasionally crashes when completely deleting the data. This might be related to the performance issue #2965.

The data may be correctly read but not immediately shown/refreshed.

I'm loading >400 entries of data from the Ivy Backup (i.e., JSON file).

To figure out the issue, does someone know where the data gets loaded in the app structure/logic so that we can start looking into it?

@ILIYANGERMANOV
Copy link
Collaborator

@biagio11 check BackupDataUseCase

@biagio11
Copy link
Contributor Author

biagio11 commented May 1, 2024

Thanks, I'll try to figure it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by the Ivy Wallet team. Ready for dev bug Something isn't working user request Feature/improvement requested by an user
Projects
None yet
Development

No branches or pull requests

3 participants