Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Domain] Build the AccountBalanceUseCase #3143

Open
1 task done
ILIYANGERMANOV opened this issue Apr 16, 2024 · 4 comments
Open
1 task done

[Domain] Build the AccountBalanceUseCase #3143

ILIYANGERMANOV opened this issue Apr 16, 2024 · 4 comments
Assignees
Labels
approved Approved by the Ivy Wallet team. Ready for dev devexp Codebase & dev experience help wanted Help us! Appreciated P0 Critical and urgent

Comments

@ILIYANGERMANOV
Copy link
Collaborator

ILIYANGERMANOV commented Apr 16, 2024

Please confirm the following

What would you like to improve?

  • Build the AccountBalanceUseCase.
  • Use the AccountStatsUseCase and the TransactionRepository
class AccountBalanceUseCase @Inject constructor(...) {
   fun calculate(account: AccountId): Map<AssetCode, NonZeroDouble>
}
  • Build the NonZeroDouble following the pattern to the PositiveDouble
  • We neee NonZeroDouble to handle the case of negative balances (credits to @Vishwa-Raghavendra)

Because...

  • Proper domain logic following the architecture and having unit + property-based tests.

Description

No response

Success Criteria

  • Follows all dev guidelines (this is a critical code so expect Requests for changes on your PR)
  • Property-based tests
  • Unit tests
@ILIYANGERMANOV ILIYANGERMANOV added devexp Codebase & dev experience approved Approved by the Ivy Wallet team. Ready for dev P0 Critical and urgent help wanted Help us! Appreciated labels Apr 16, 2024
@ivywallet
Copy link

Thank you @ILIYANGERMANOV for raising Issue #3143! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

@priyanshuborole
Copy link

priyanshuborole commented Apr 17, 2024

I'm on it

@priyanshuborole
Copy link

"I'm on it"

@ivywallet
Copy link

Thank you for your interest @priyanshuborole! 🎉
Issue #3143 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by the Ivy Wallet team. Ready for dev devexp Codebase & dev experience help wanted Help us! Appreciated P0 Critical and urgent
Projects
None yet
Development

No branches or pull requests

3 participants