Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH DEBT] Incomplete/undefined config schemas #2164

Open
adam-vessey opened this issue Sep 8, 2022 · 2 comments
Open

[TECH DEBT] Incomplete/undefined config schemas #2164

adam-vessey opened this issue Sep 8, 2022 · 2 comments
Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)

Comments

@adam-vessey
Copy link
Contributor

Overview of feature request

Coming out of the starter site project to replace islandora_defaults, it was noticed that there's a number of different pieces of config defined by Islandora which are not described by a schema: https://github.com/adam-vessey/islandora-starter-site/runs/8248656015?check_suite_focus=true#step:8:9

Ideally, all configuration should be described.

What kind of user is the feature intended for?
(Example user roles: Collections Manager, Developer, Systems Administrator, or User)

Of interest to developers and sys admins, generally.

What inspired the request?

What existing behavior do you want changed?

Any brand new behavior do you want to add to Islandora?

Any related open or closed issues to this feature request?

@adam-vessey adam-vessey added the Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’) label Sep 8, 2022
@adam-vessey
Copy link
Contributor Author

Feel like I should highlight, but as of Drupal 9.3, the schemas are used to establish the order of properties in exported configurations, so having things fully defined should (eventually) lead to cleaner diffs with configuration changes.

@whikloj
Copy link
Member

whikloj commented Sep 15, 2022

I'll leave this open for now to see if there are other schemas to be fixed.

But this also is bringing to light other configuration issues where variable type is not matching the configuration.

core.entity_form_display.node.islandora_object.default:content.field_linked_agent.settings.size       variable type is string but applied schema class is  Drupal\Core\TypedData\Plugin\DataType\IntegerData

and the config shows

 field_linked_agent:
    type: typed_relation_default
    weight: 3
    region: content
    settings:
      match_operator: CONTAINS
      size: '60'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)
Projects
None yet
Development

No branches or pull requests

2 participants