Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Info about when invoices or quotes were sent to clients #1025

Open
mheiduk opened this issue Jan 30, 2024 · 6 comments
Open
Labels
Feature Request Improvement or Feature Request

Comments

@mheiduk
Copy link
Contributor

mheiduk commented Jan 30, 2024

My client is missing an info about when invoices or quotes were sent to clients. Especially when clients are missing the due date it would be good to know when they were getting a reminder.

Expected Behavior

A date column/field "Sent On" for invoices and quotes.

Current Behavior

No info when invoices or quotes were sent.

Possible Solution/Implementation/Description

New columns in the db tables invoice_date_sent DATETIME and quote_date_sent DATETIME with the info about when invoices were sent to the clients. Will be updated in the mark_sent functions.

New column on the invoices/quotes table overview. Furthermore a new datetime field at invoice/quote detail level.

A pull request is already in the making, but before that I have to test it a little bit more. Any further input/suggestion is welcome.

@nielsdrost7
Copy link
Contributor

Any further input/suggestion is welcome
Well, I love the idea.
Are you sure you don't want a list of all the dates you sent that invoice/quote to the customer?
That means another table instead of those new fields.

invoice_date_sent
I would already start with the 'laravel' type dates, example: invoice_sent_at

Those new date fields, I wouldn't place them at the end of the table, but after a certain column.

Just a suggestion, otherwise it's going to be a mess with all kinds of fields spread everywhere in those 2 tables.

@mheiduk
Copy link
Contributor Author

mheiduk commented Jan 31, 2024

Are you sure you don't want a list of all the dates you sent that invoice/quote to the customer?
That means another table instead of those new fields.

Hm, interesting thought. Would be some kind of log then. I'll look into it.

invoice_date_sent
I would already start with the 'laravel' type dates, example: invoice_sent_at

Good point, thx.

Those new date fields, I wouldn't place them at the end of the table, but after a certain column.
Just a suggestion, otherwise it's going to be a mess with all kinds of fields spread everywhere in those 2 tables.

Yes, in my current draft I add the new columns after invoice_date_due respectively quote_date_expires.

@Verony-makesIT
Copy link
Contributor

@mheiduk,
my function "update_invoice_due_dates($invoice_id) in Mdl_invoices.php" already does this for invoices.

See Feature Request #895.
When sending an invoice, the fields (invoice_date_created and invoice_date_due) in the ip_invoices db are updated to the current dates.
That way you can check which date the invoice was actually sent and which is the due date.
However, this behavior can be adjusted in "Settings - Invoices".
image

@mheiduk
Copy link
Contributor Author

mheiduk commented Jan 31, 2024

@Verony-makesIT thanks! I am aware of this feature, but this led to confusion for my client, because the invoice creation date will also be updated. This is in my opinion a wrong behavior, the creation date should always be the same.

If someone wants this feature, it should be at least opt-in.

@Verony-makesIT
Copy link
Contributor

@mheiduk,
it can indeed be confusing, and strictly speaking, you and/or your client are right.
Those who have to pay the invoice (before the due date) don't really care when the invoice was created, originally or technically. What does matter to them is that they can use the set days until the due date to pay their invoices.
Now, by overwriting the creation date with the shipment date, the due date is set up correctly.
In my opinion, both for the supplier and customer, this is the most fair and equitable approach.
Just my 2 cents...

And if your customer is not in favor of this, they can easily change this setting.

@mheiduk
Copy link
Contributor Author

mheiduk commented Feb 2, 2024

@Verony-makesIT I understand your point, but it's in a legal and also technical perspective not right to do that. A creation date is per definition the date of the creation and should not be altered.

@nielsdrost7 nielsdrost7 added the Feature Request Improvement or Feature Request label Mar 9, 2024
@nielsdrost7 nielsdrost7 changed the title [Feature] Info about when invoices or quotes were sent to clients [Feature Request] Info about when invoices or quotes were sent to clients Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Improvement or Feature Request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants