Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translations in guest url #1021

Open
wendelinux opened this issue Jan 28, 2024 · 2 comments
Open

translations in guest url #1021

wendelinux opened this issue Jan 28, 2024 · 2 comments
Assignees
Labels
More Information Required Please provide more details to describe your issue/request Needs review Work in Progress

Comments

@wendelinux
Copy link

guest url is always in english, while it should have the client's language

Expected Behavior

for example

lang("vat_id_short") should spit out BTW in dutch

Current Behavior

lang("vat_id_short") spits out VAT in dutch

Issue is in guest url for invoices and for quotes

@wendelinux
Copy link
Author

after research i found out how it works, but logic is incorrect.
when having an active session, the language of that session is beeing used.
the guest url is clearly from guest and always should be displayed in connected client's language.
not userlanguage from the running session

@nielsdrost7
Copy link
Contributor

when having an active session, the language of that session is beeing used.
the guest url is clearly from guest and always should be displayed in connected client's language

Do you have an indication on where to look for the solution?
What is your setting for match ip in your ipconfig.php?
Is it same problem in incognito browser window?

So admin in main browser and guest in incognito?

@nielsdrost7 nielsdrost7 added Needs review Work in Progress More Information Required Please provide more details to describe your issue/request labels Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
More Information Required Please provide more details to describe your issue/request Needs review Work in Progress
Projects
None yet
Development

No branches or pull requests

2 participants