Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] copy quote needs confirmation popup model box #1019

Open
irockbot opened this issue Jan 26, 2024 · 6 comments
Open

[Feature Request] copy quote needs confirmation popup model box #1019

irockbot opened this issue Jan 26, 2024 · 6 comments
Assignees
Labels
Milestone

Comments

@irockbot
Copy link

Expected Behavior

When you click copy quote, a modal popup box confirmation says Quote has been copied successfully or something like that or a redirection to all quotes section may be perfect.

Current Behavior

Currently it stays dead in the current page when you click copy quote, eventhough the quote is copied in background

Steps to Reproduce

  1. go to quotes section
  2. Click any quotes
  3. Under the options, click copy quote
  4. It stays in current page without any action confirmation.
@irockbot
Copy link
Author

v1.6

@naui95 naui95 self-assigned this Jan 26, 2024
@naui95 naui95 added this to the 1.6.2 milestone Jan 26, 2024
@Verony-makesIT
Copy link
Contributor

@naui95,
FYI: this problem was raised some time ago (in issue #841) and solved by me (#932).
Your comment back then.
This issue was also already added to the 1.6.2 millestone on 23/12/2023 by Niels Drost.

@irockbot
Copy link
Author

@Verony-makesIT Thank you for your response. Glad it has been fixed it already. This should be included in 1.6.1 stable. I don't know what makes the devs to place hold on this. This is very very important bug and easily noticeable.

@naui95
Copy link
Contributor

naui95 commented Jan 26, 2024

@naui95, FYI: this problem was raised some time ago (in issue #841) and solved by me (#932). Your comment back then. This issue was also already added to the 1.6.2 millestone on 23/12/2023 by Niels Drost.

Thank you @Verony-makesIT for the hint. This issue is fixed by #932

@nielsdrost7
Copy link
Contributor

@irockbot the solution with this pull-request will be included in version 1.6.2

@irockbot
Copy link
Author

@nielsdrost7 Thank you! Kudos to all who contributed for this great project.

@nielsdrost7 nielsdrost7 changed the title copy quote needs confirmation popup model box [Feature Request] copy quote needs confirmation popup model box Mar 9, 2024
@nielsdrost7 nielsdrost7 added the Feature Request Improvement or Feature Request label Mar 10, 2024
@naui95 naui95 added Bug and removed Feature Request Improvement or Feature Request labels Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants