Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Extra field "title" for personal client information #1003

Open
onny opened this issue Nov 29, 2023 · 3 comments · May be fixed by #1007
Open

[Feature Request] Extra field "title" for personal client information #1003

onny opened this issue Nov 29, 2023 · 3 comments · May be fixed by #1007
Assignees
Labels
Feature Request Improvement or Feature Request
Milestone

Comments

@onny
Copy link

onny commented Nov 29, 2023

It would be nice to have an extra field in the personal information area of a client for specifying a title.
This should get rendered in the invoice pdf in the billing to area:

Mr.
Christian Bauer
Example Street 1
Example City
etc.

The extra field could be a drop down for common titles like "Mr" or "Mrs" but also should provide a free form text field in case one would need to specify a complex title (including academic title etc).

@nielsdrost7
Copy link
Contributor

nielsdrost7 commented Nov 29, 2023

So:

  • a select box with a list with contents:
    [array of settings like Mr., Mrs, etc] AND a list-item: Custom (or 'type it yourself).
  • Save the chosen title to "create field in clients table
  • The values Mr., Mrs, etc come from a ... translation, so the keys that we're inventing are translatable keys.
  • Show the newly invented title in ... Invoices? All templates? clients index?
  • Make that newly invented field selectable in ... email templates?

Those keys we're inventing ... a setting in ipconfig.php?
For example:
SETTING_CLIENT_TITLE='mr,mrs,doctor,professor'
and then we turn that little list into a selectbox, translated into the user chosen language (if translated, otherwise, fallback, English)

Something like that?

@KevinJ30
Copy link
Contributor

KevinJ30 commented Dec 12, 2023

@nielsdrost7

Can't we use a php ENUM instead of the setting in the ipconfig file to represent this information ?
Because in all cases a new production run will be required to change this information ?

@nielsdrost7
Copy link
Contributor

Yes we can, but it would still be a select box with that list of possibilities.
Plus I know someone who wants to manipulate it through the ipconfig file.

@KevinJ30 would you like to make a branch with the suggested solution? For example with your suggestion of that enum you were talking about

@nielsdrost7 nielsdrost7 added the Feature Request Improvement or Feature Request label Dec 17, 2023
@nielsdrost7 nielsdrost7 self-assigned this Dec 17, 2023
@nielsdrost7 nielsdrost7 linked a pull request Dec 17, 2023 that will close this issue
@nielsdrost7 nielsdrost7 added this to the 1.6.2 milestone Dec 17, 2023
@nielsdrost7 nielsdrost7 changed the title [Feature request] Extra field "title" for personal client information [Feature Request] Extra field "title" for personal client information Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Improvement or Feature Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants