Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation and important constants on TangoServiceClientNodes #370

Open
adamantivm opened this issue Aug 3, 2017 · 1 comment

Comments

@adamantivm
Copy link

Trying to understand the expected behavior of TangoServiceClientNode and its callback is currently very difficult and not fully documented.

Two things that I am running into now, which I can only resolve by looking at the source code of TangoRosStreamer and copying how it is implemented there:

1- Understanding what is the expected behavior of callTangoConnectService
2- How to tell if the service started successfully or not
3- What is the meaning of the status codes returned by onTangoStatus

I suggest clarifying this in the wiki and also adding the following enum as part of the TangoServicClientNode:

// Symmetric implementation to tango_ros_node.h.
enum TangoStatus {
    UNKNOWN,
    SERVICE_NOT_CONNECTED,
    NO_FIRST_VALID_POSE,
    SERVICE_CONNECTED
}
@PerrineAguiar
Copy link

1 and 2 - Tutorial has been updated: http://wiki.ros.org/tango_ros_streamer/tango_ros_node#Start_streaming_Tango_data
3- Wiki has been updated: http://wiki.ros.org/tango_ros_streamer#Published_Topics

TODO: add the enum as part of the TangoServiceClientNode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants