Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Correct way to document implementations of methods in new style #235

Open
PokhodenkoSA opened this issue Oct 18, 2019 · 1 comment
Open

Comments

@PokhodenkoSA
Copy link
Contributor

PokhodenkoSA commented Oct 18, 2019

Actually axis could be a string ('index' or 'columns'), not only an integer. You could add string type here. Moreover you could check on typing stage of the implementation that axis type is able to be a string.

Originally posted by @densmirn in #227

@PokhodenkoSA
Copy link
Contributor Author

Pandas docs: {index (0)}
So it supports integers and columns and names.
I prefer copy docs from Pandas and add flags like unsupported to indicate that parameter behave not like in Pandas.

@PokhodenkoSA PokhodenkoSA assigned densmirn and unassigned densmirn Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants