Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen button does not work #693

Open
PaulHax opened this issue Nov 18, 2023 · 3 comments
Open

Fullscreen button does not work #693

PaulHax opened this issue Nov 18, 2023 · 3 comments

Comments

@PaulHax
Copy link
Collaborator

PaulHax commented Nov 18, 2023

The fullscreen button does not work.
image

Works in https://github.com/InsightSoftwareConsortium/itk-viewer-bootstrap-ui

Probably need to add allow="fullscreen" to the iframe:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#allowfullscreen

@PaulHax
Copy link
Collaborator Author

PaulHax commented Nov 19, 2023

Given imjoy docs
https://github.com/imjoy-team/ImJoy/blob/c255d9cda9dc19d441fb7cf1eaca806e5ec71af8/docs/development.md#permissions

I tried this: PaulHax@a796f03

But did not work. Maybe we can querySelector() in python for the iframe and set allow="fullscreen"?

@thewtex
Copy link
Member

thewtex commented Nov 30, 2023

CC @bnmajor @oeway

@oeway
Copy link
Collaborator

oeway commented Nov 30, 2023

Hi I just checked, it appears that it's not possible to request fullscreen from within the iframe itself, the fullscreen should be done in the host window. This means we need to implement it in python as suggested by @PaulHax . And we might need to still add allow="fullscreen" to the iframe as I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants