[1.20] Black Hole Units (Item Change Bug)

[SD-ITLab]

Industrial Foregoing Version:
1.20.1-3.5.12

Titanium Version:
1.20.1-3.8.25

Crashlog If Applicable (Upload to pastebin/gist):
Hello dear IF team,

My friend is using the Black Hole Units from Industrial Foregoing as storage locations for items.
(Due to the high quantities for individual items)

These are connected to the ME system via the storage bus.
However, problems have occurred several times.

Example:
Black hole unit filled with 200 million Infernium Essence, but after a while (when exactly I can't say, maybe after a restart?) the item suddenly changed to something else.
This has not happened with all units so far... out of currently 20 / 30 units there are 3 that showed the error.

We have already tried to work with filters in the StorageBus to only pull the specific item in/out... This did not bring any improvement.
Unfortunately I cannot reproduce this exactly.

[Skylla7629]

I am having the exact same issue with:

Industrial Foregoing Version:
1.19.2-3.3.2.3-7

Titanium Version:
1.19.2-3.7.4-28

I was also able to reproduce this bug:

It occurs if you move a large quantity of Items of different type in the ME System (e. g. with an IO Port clearing discs) into the Black Hole controller.
I have also tied disabeling Viod Items in the Black Hole unit, aswell as setting the Filter in the Black Hole Units themselves both leads to the same issue still.

The changed items as of now are:

Soul Sand
Cobbled Deepslate
Lapis Lazuli
Diorite
Scoria (Create)
Prosperity Shard (Mystical Agriculture)
Inferium Essence (Mystical Agriculture)

to

Dirt
Magma Block
Prosperity Shard (Mystical Agriculture) (yes, I got some back again (: )

All items are stored in the same Black Hole Controller

I also had a look at the nbt tags after this bug and even though the canged Items are in a different Black hole Unit than the one the item is actually supposed to be in, the items still have the exact same nbt as they should have, and no remnants of the old nbts are visible.

Additionally: I had this happen with the Supreme and Simple Black Hole Units mixed together, although item changes also appeared when only 1 type was used.

[notcake]

I've run into this issue twice now.

I think Black Hole Units will enter a buggy state that allows for item transmutation when the last insert operation's quantity is <= 0 when casted to a signed byte. The cast happens inside ItemStack.serializeNBT().

Reproduction Steps

Black Hole Units

1. Insert x items in one operation, where (byte)x <= 0, eg. 128. The easiest way to do this is to cancel a large AE2 crafting operation.
2. Break the Black Hole Unit.
3. Place the Black Hole Unit. The Black Hole Unit is now bugged. I think ItemStack.isEmpty() returns true inside BlackHoleHandler.isItemValid() and allows anything to be inserted.
4. Insert an arbitrary item. The Black Hole Unit now contains the new item, with a combined count of the previous item and the new item.

Unloading and reloading the chunk containing the Black Hole Unit might also work instead of steps 2 and 3.

Black Hole Units within a Black Hole Controller

1. Insert x items in one operation, where (byte)x <= 0, eg. 128. The easiest way to do this is to cancel a large AE2 crafting operation.
2. The Black Hole Unit is now bugged. I think ItemStack.isEmpty() returns true inside BLHBlockItemHandlerItemStack .isItemValid() and allows anything to be inserted.
3. Insert an arbitrary item. The Black Hole Unit now contains the new item, with a combined count of the previous item and the new item.