Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Variable Name" (grvy:org.codenarc.rule.naming.VariableNameRule.fixed) incorrectly classified as "Bug" #39

Open
alixwar opened this issue Nov 4, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@alixwar
Copy link

alixwar commented Nov 4, 2020

Hi,

SonarQube 8.5 classifies grvy:org.codenarc.rule.naming.VariableNameRule.fixed as a "Bug" whereas I argue that it should be classified as a "Code smell".

From the official documentation:

Bug | An issue that represents something wrong in the code. If this has not broken yet, it will, and probably at the worst possible moment. This needs to be fixed. Yesterday.

Code Smell | A maintainability-related issue in the code. Leaving it as-is means that at best maintainers will have a harder time than they should making changes to the code. At worst, they'll be so confused by the state of the code that they'll introduce additional errors as they make changes.

Source: https://docs.sonarqube.org/latest/user-guide/concepts/

"Variable Name" (grvy:org.codenarc.rule.naming.VariableNameRule.fixed) rule description:

Verifies that the name of each variable matches a regular expression. By default it checks that non-final variable names start with a lowercase letter and contains only letters or numbers. By default, final variable names start with an uppercase letter and contain only uppercase letters, numbers and underscores.

Versions:

  • Groovy plugin version 1.6
  • SonarQube 8.5.1

Related: #14

@TobiX TobiX added the bug Something isn't working label May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants