You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Created a new getNavComponents() function, which returns an object containing the siblings of the search-bar.
Using this function and de-structuring, {rightSideSlot, leftSideSlot, rightAssignedNodes, leftAssignedNodes, navbarProfile, leftMenuItems, rightMenuItems, topRowWrapper} - constants can be extracted. This reduces code repetition.
And using event emission of internalState in search-bar component, to prevent changing state when component is loaded.
@akashyeole
1 - Please write a proper description
2 - By dividing the code inside handleSearchBarToggle into two separate functions, you are using a lot of repetitive statements. Can you try to outsource some of them into separate re-usable functions so they don't repeat? eg: this.el.shadowRoot.querySelector('.navbar__sidebar-top-row-wrapper') is repeated twice.
3 - Inside componentDidLoad(), you are invking adjustSearchBarWidth(), which checks if isOpen prop is true, and if it is, it invokes the hideNavComponents() func, which changes the searchBarIsOpen State. Changing a State inside componentDidLoad() is usually not recommended, and should be avoided, as the warning error shows in the console log. What you can do instead is emit the internalState value of the Search-bar from inside the search-bar component inside the componentWillLoad(). In that case, you won't need the two extra functioins that you created (adjustSearchBarWidth and getSearchBar)
tishoyanchev
changed the title
Navbar: bug fix where search was not rendered in full width search bar set to open by default
Navbar: fixed bug affecting the search-bar's isOpen prop on initial load
May 28, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tishoyanchev
changed the title
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Created a new
getNavComponents()function, which returns an object containing the siblings of the search-bar.Using this function and de-structuring, {rightSideSlot, leftSideSlot, rightAssignedNodes, leftAssignedNodes, navbarProfile, leftMenuItems, rightMenuItems, topRowWrapper} - constants can be extracted. This reduces code repetition.
And using event emission of
internalStatein search-bar component, to prevent changing state when component is loaded.Related Issue
#1227
📦 Published PR as canary version:
21.9.1--canary.1236.3ce35e16b7e34b687f6448e294b667380db13343.0✨ Test out this PR locally via:
npm install @infineon/infineon-design-system-stencil@21.9.1--canary.1236.3ce35e16b7e34b687f6448e294b667380db13343.0 # or yarn add @infineon/infineon-design-system-stencil@21.9.1--canary.1236.3ce35e16b7e34b687f6448e294b667380db13343.0