Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug in /sharpy/aero/modals/aerogrid.py #209

Open
LeeElvis opened this issue Aug 11, 2022 · 1 comment
Open

Potential bug in /sharpy/aero/modals/aerogrid.py #209

LeeElvis opened this issue Aug 11, 2022 · 1 comment

Comments

@LeeElvis
Copy link

Describe the bug
In lines 273, 280 and 313, according to the Aerodynamics input h5file: I think that the control surface info ['control_surface_hinge_coords'] should be ['control_surface_hinge_coord'].
Thank you.

@ACea15
Copy link
Collaborator

ACea15 commented Sep 6, 2022

Nicely spot Lee, you could still run your model with 'control_surface_hinge_coords' if you put it in the input h5-file, but indeed in the docs it is 'control_surface_hinge_coord' and doing a -grep shows inputs in the examples are without the 's'.
Totally looks like a refactoring that missed that line, what is more worrying is that none of the tests picked that up.
Will fix it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants