Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with permit number #123

Closed
1 of 3 tasks
davidorme opened this issue Apr 18, 2024 · 1 comment
Closed
1 of 3 tasks

Fix issues with permit number #123

davidorme opened this issue Apr 18, 2024 · 1 comment
Assignees
@jacobcook1995

Comments

@davidorme
Copy link
Collaborator

davidorme commented Apr 18, 2024 •
edited by jacobcook1995

The sdv checking appears to crash when a permit authority is named but no number is provided.

We need to:

  • Verify this actually causes a crash
  • Fix the crash
  • Add docs to say that missing permit numbers can simply use a null value of "Unknown" or similar.
@jacobcook1995 jacobcook1995 self-assigned this Apr 19, 2024
@jacobcook1995
Copy link
Collaborator

jacobcook1995 commented Apr 19, 2024 •
edited

I haven't been able to replicate the crash on Mac or Ubuntu, so is tricky to fix. I guess the documentation change is a good thing to do regardless though

@jacobcook1995 jacobcook1995 mentioned this issue Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobcook1995 jacobcook1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidorme @jacobcook1995