Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a draft Canopy class #230

Open
davidorme opened this issue May 7, 2024 · 0 comments · May be fixed by #231
Open

Create a draft Canopy class #230

davidorme opened this issue May 7, 2024 · 0 comments · May be fixed by #231
Assignees

Comments

@davidorme
Copy link
Collaborator

This new feature is to take the canopy model description added in the WIP pull request #227 and implement the creation of a Canopy instance:

Approximate specification:

  • The Canopy class should take a Community object (as in the current sketch) as an __init__ argument.

  • It should populate attributes that record:

    • the vertical heights of the canopy layers ($z^*_l$), which will be a one dimensional array of heights in metres.
    • the vertical light extinction profile through the canopy layers, as a one dimensional array of proportion of down-welling Tlight absorbed layer $l$
    • the leaf area within each layer for each cohort: this is a 2 dimensional array (n cohorts x n layers) of areas in metres squared.

It isn't clear to me that this needs anything public except the __init__ method? It makes sense to break up the calculations into logical subfunctions for testing and readability, but basically it is one big calculation. We could have an explicit calculate_canopy step?

@AmyOctoCat AmyOctoCat linked a pull request May 9, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants