Rebuild of QA chain using ruff #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
j-emberton
approved these changes
Jun 6, 2024
j-emberton
reviewed
Jun 6, 2024
| @@ -267,7 +267,8 @@ def __init__( | |||
| "co2", | |||
| "patm", | |||
| "vpd", | |||
| ] + optimal_chi_class.requires | |||
| *optimal_chi_class.requires, | |||
There was a problem hiding this comment.
This seems like a strange change. Is it separate to the edits to support ruff?
There was a problem hiding this comment.
Yeah - it's this rule: https://docs.astral.sh/ruff/rules/collection-literal-concatenation/
I believe them, but it puzzled me too!
There was a problem hiding this comment.
yeah, its not super obvious is it!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #220 +/- ##
===========================================
+ Coverage 95.12% 95.24% +0.11%
===========================================
Files 30 28 -2
Lines 1724 1703 -21
===========================================
- Hits 1640 1622 -18
+ Misses 84 81 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches the QA chain away from
flake8,black,isortandpyupgradetoruff: it is significantly faster and looks to be more robust and less version sensitive. This is needed to close #226 - we should be able to support Python 3.12 seamlessly with the new QA chain.Although
pytest-ruffexists, I have also removed QA plugins from thepytestconfiguration, sopytest-mypyandpytest-flake8are now retired and not replaced. The rationale for this is that they significantly slow down testing - which is about making sure the code works - and the QA steps are already enforced viapre-commiton local machines and the GA workflows.Fixes #219
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks