New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat label everywhere as class, not string #52
Comments
Do you mean interpretate as enum or something? Label looks more like external entity as for me, isn't it's better place for that in resources? |
What I am saying is that sometimes in class signatures labels are passed as strings and somewhere as class Label, so maybe it makes sense to unify it, because it's the same logical entity |
This seems pretty straight forward, but to clarify, in EasyLabelsStorage.kt we would now return a HashSet filled with the Label data object, right? If so, I'll make this PR later tonight. |
@ggenya132 basically, yes. What I would like to point out is that there is some logic according to label equality checks: Right now I explicitly call It would definitely makes sense to put this logic into a single place - maybe |
@IgorPerikov
|
@ggenya132 on the |
@IgorPerikov |
@ggenya132 how's your progress so far? need help? |
Places to fix:
The text was updated successfully, but these errors were encountered: