Accept Datatype Sensitive for Secrets

[cocker-cc]

No description provided.

[cla-bot]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @cocker-cc

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

[lbetz]

In these cases the data type Sensitive is superfluous because the passwords are made visible again with show_diff.

[cocker-cc]

In these cases the data type Sensitive is superfluous because the passwords are made visible again with show_diff.

What do you mean by "in these cases"?

To make it clear: My main Goal is not to make Passwords invisible – although this is nice.

My Effort to make many Component-Modules sensitive-aware is: As an Author of Profile-Modules I do not want to fiddle with Sensitive and unwrap at all. My Passwords come out of Vault, and Vault returns Passwords as Sensitive[String]. I just want to pass over these Passwords to the Component-Modules without any further ado. I my World the Component-Modules "just have to work".

In an ideal World even the Component-Module should never use unwrap. In most Cases EPP-Files should be used instead of ERB-Files, because EPP itself is able to handle Sensitive natively.

[cla-bot]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @cocker-cc

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

[cocker-cc]

I did a git rebase upstream/master && git push -f.

[lbetz]

Thanks for your detailed explanation. Now I understand and will add your changes to the upcoming release. Fortunately I was able to hold myself back from a release.

[lbetz]

What's about keys and certificates for TLS?

[cocker-cc]

What's about keys and certificates for TLS?

I created this PR for the regsubst of SSL-Keys.

[lbetz]

refs #689