Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird history behavior since v2.12.0 #5178

Open
nilmerg opened this issue Feb 2, 2024 · 0 comments · May be fixed by #5179
Open

Weird history behavior since v2.12.0 #5178

nilmerg opened this issue Feb 2, 2024 · 0 comments · May be fixed by #5179
Assignees
@nilmerg
Labels
area/navigation Affects the navigation bug Something isn't working
Milestone
2.12.2

Comments

@nilmerg
Copy link
Member

nilmerg commented Feb 2, 2024

Describe the bug

  • Navigating to a view that is opened in the second column doesn't update the history stack properly: Navigating back in this case, doesn't allow to navigate forward again.
  • Navigating to a view from the sidebar that is opened in the first column, while the second column is open, an unnecessary push to the stack happens

Expected behavior

  • Navigating forward should be possible
  • Navigating back should reproduce the view prior the sidebar navigation

Your Environment

  • Icinga Web 2 version and modules (System - About): 2.12.0

Additional context

caused by #5055
@nilmerg nilmerg added bug Something isn't working area/navigation Affects the navigation labels Feb 2, 2024
@nilmerg nilmerg added this to the 2.12.2 milestone Feb 2, 2024
@nilmerg nilmerg self-assigned this Feb 2, 2024
nilmerg added a commit that referenced this issue Feb 2, 2024
@nilmerg
js: Explicitly update history when col2 is closed
6ba4a6e 
Instead of doing this by default. There are too many
cases where this isn't necessary at all.

fixes #5178
@nilmerg nilmerg linked a pull request Feb 2, 2024 that will close this issue
Open
nilmerg added a commit that referenced this issue Feb 9, 2024
@nilmerg
js: Explicitly update history when col2 is closed
107ceb0 
Instead of doing this by default. There are too many
cases where this isn't necessary at all.

fixes #5178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilmerg nilmerg

Labels
area/navigation Affects the navigation bug Something isn't working
Projects
None yet
Milestone
2.12.2
Development

Successfully merging a pull request may close this issue.

js: Explicitly update history when col2 is closed Icinga/icingaweb2
1 participant
@nilmerg