Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type to reflect the actual type of internal event #162

Open
nilmerg opened this issue Feb 26, 2024 · 0 comments · May be fixed by #175
Open

Use type to reflect the actual type of internal event #162

nilmerg opened this issue Feb 26, 2024 · 0 comments · May be fixed by #175
Assignees
@oxzi

Comments

@nilmerg
Copy link
Member

nilmerg commented Feb 26, 2024

At the moment, internal events use the type name internal which is rather useless for Web.

The type should use specific names to indicate what the event is about.

It's currently used in two cases:

  • Incident age thresholds
  • Incident reevaluation at startup

There may be more added in the future. We need to make sure that there are no such surprises for Web anymore, @julianbrost suggested to use an enum for event.type to ensure that.
This was referenced Feb 26, 2024
Closed
Closed
oxzi added a commit that referenced this issue Apr 15, 2024
@oxzi
Distinct "internal" Event Types
366fb38 
The "internal" event type was used both for scheduled reevaluations and
for initial reevaluations during startup. This type is currently being
used at two different points for two distinct topics: scheduled
reevaluations and initial reevaluations during startup.

This event type was now split into "reevaluation-scheduled" and
"reevaluation-startup" to distinct those types.

To ensure database-level stability, the column type was changed from
text to a custom enum.

Closes #162.
oxzi added a commit that referenced this issue Apr 15, 2024
@oxzi
Distinct "internal" Event Types
af4b719 
The "internal" event type was used both for scheduled reevaluations and
for initial reevaluations during startup. This type is currently being
used at two different points for two distinct topics: scheduled
reevaluations and initial reevaluations during startup.

This event type was now split into "reevaluation-scheduled" and
"reevaluation-startup" to distinct those types.

To ensure database-level stability, the column type was changed from
text to a custom enum.

Closes #162.
@oxzi oxzi linked a pull request Apr 15, 2024 that will close this issue
Open
oxzi added a commit that referenced this issue Apr 16, 2024
@oxzi
Distinct "internal" Event Types
1736b30 
The "internal" event type was used both for scheduled reevaluations due
to their age and for initial reevaluations during startup. This type is
currently being used at two different points for two distinct topics:
age-based reevaluations and initial reevaluations during startup.

This event type was now split into "reevaluation-age" and
"reevaluation-startup" to distinct those types.

To ensure database-level stability, the column type was changed from
text to a custom enum.

Closes #162.
oxzi added a commit that referenced this issue Apr 17, 2024
@oxzi
Distinct "internal" Event Types
d67ec1e 
It was ambiguous what the "internal" event type especially stand for. As
currently both of its use cases are some kind of reevaluation - either
during the program's startup or due to an event's age -, it was renamed
to "reevaluation".

To ensure database-level stability, the column type was changed from
text to a custom enum.

Closes #162.
@julianbrost julianbrost mentioned this issue Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxzi oxzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Distinct "internal" Event Types Icinga/icinga-notifications
2 participants
@oxzi @nilmerg