Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate configuration were possible #143

Open
dgoetz opened this issue Dec 18, 2023 · 1 comment
Open

Avoid duplicate configuration were possible #143

dgoetz opened this issue Dec 18, 2023 · 1 comment

Comments

@dgoetz
Copy link

dgoetz commented Dec 18, 2023

While looking at the current state of the module, we found one potential issue of the URL for Icinga Web 2 has to be defined in two different locations. In this case it is once defined by the Icinga 2 integration utilizing a constant defined in Icinga 2 and another time in the file based configuration of the Notifications daemon. This may result in both having different values.

I understand the logic, that every component can send event to Icinga Notifications and can include the URL while doing so, but I would hope there could be a single point of configuration for this. So perhaps working with a placeholder that is then replaced by Notifications as a single source for it.

Perhaps it makes also sense to have it configured via the Web interface and stored in the Database instead of a file. Another idea would be then allow an override at user level or the rule set in case you have an internal and an external URL or something similar in your environment.

@oxzi
Copy link
Member

oxzi commented Dec 18, 2023

The current Icinga 2 integration with the custom icinga2.conf file, specifying the Icinga Web 2 URL as IcingaNotificationsIcingaWebUrl, is planned to be only a temporary solution. After #112 is finalized, there might be no more use for a custom Icinga 2 configuration and the Icinga Web 2 URL is then only present in the Icinga Notifications configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants