Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional session table in the notifications database #118

Open
ncosta-ic opened this issue Oct 26, 2023 · 1 comment · May be fixed by #136
Open

Additional session table in the notifications database #118

ncosta-ic opened this issue Oct 26, 2023 · 1 comment · May be fixed by #136

Comments

@ncosta-ic
Copy link
Member

ncosta-ic commented Oct 26, 2023 •
edited

What's this issue for?

We are currently working on an implementation enabling native desktop notifications provided through the web part of the notifications module (see #135).

The plan is to introduce a PHP based daemon providing the application logic to enable direct interaction with the web backend. After the initial usage in the notifications module, we essentially want to generalize it and move it over to the icingaweb2 module once it reaches a usable state supporting different requirements for other use-cases.

Now for the time being, it will be used in conjunction with the notifications module and its desktop notifications and we need to keep track of the currently authenticated sessions. As it does not really make sense to create a new database just for this limited and light-structured data, we want to make use of the existing notifications database, which brings me to the main point of this issue.

Additions to the codebase

An update of the schema/pgsql/schema.sql is needed to include the new table definition. Additionally, a schema/pgsql /upgrades/?.sql file for existing installations will be provided as well.

Are there any objections or architecturial choices from your part that speak against such a course of action?
@julianbrost
Copy link
Collaborator

Are there any objections or architecturial choices from your part that speak against such a course of action?

If the Go daemon can safely ignore that table, no. (I'll look over the schema change, if I find it strange, maybe you'll get a "are you sure this a good idea?" question, but that's about it. 😅)

ncosta-ic added a commit that referenced this issue Nov 28, 2023
@ncosta-ic
feat(desktop-notifications): add new table for session management
7af001b 
This feature introduces a new session table which is needed by the `icinga-notifications-web` project. It stores the current authenticated sessions into the table which allows the background daemon (php-based) to validate a connection and its corresponding browser to an authenticated session.
Read #118 for more information about this addition.
@ncosta-ic ncosta-ic linked a pull request Nov 28, 2023 that will close this issue
Open
ncosta-ic added a commit that referenced this issue Nov 29, 2023
@ncosta-ic
feat(desktop-notifications): add new table for session management
11f4cfb 
This feature introduces a new session table which is needed by the `icinga-notifications-web` project. It stores the current authenticated sessions into the table which allows the background daemon (php-based) to validate a connection and its corresponding browser to an authenticated session.
Read #118 for more information about this addition.
@nilmerg nilmerg linked a pull request Apr 10, 2024 that will close this issue
Introduce table for session management #136
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce table for session management Icinga/icinga-notifications
2 participants
@julianbrost @ncosta-ic