New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce desktop notifications #146
base: main
Are you sure you want to change the base?
Conversation
f1c6c63
to
39a10c5
Compare
e76e36b
to
9bda33d
Compare
9bda33d
to
73d685d
Compare
Current observationsThe general logic that triggers the desktop notifications is pretty stable now. However, there are some issues with mobile devices, that are currently unsolved. iOS
This results in the app stopping to show notifications after the home-screen application was put into background or if the phone got locked. Android
Possible fix?One way around this problem, albeit being a real ugly one, would be to start a freshness timer in the service worker context once the tab gets the visiblestate event fired with a value of |
ddcd2e0
to
5853886
Compare
274952d
to
0a3eca3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far looks good to me.
b5110b6
to
f17f8a0
Compare
491cb1c
to
305d415
Compare
As it seems like you're fine with the changes that I implemented, you might want to approve your review. It still needs the approval of @sukhwinder33445 and @nilmerg either way. |
305d415
to
8204322
Compare
8204322
to
1be0b4f
Compare
Targets #135
Depends on Icinga/icinga-notifications#136