Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use features only available since PHP 7.3 #126

Open
yhabteab opened this issue Sep 25, 2023 · 1 comment
Open

Don't use features only available since PHP 7.3 #126

yhabteab opened this issue Sep 25, 2023 · 1 comment

Comments

@yhabteab
Copy link
Member

I noticed in several places where array_key_last() is used, which is available since PHP 7.3.

$key = array_key_last($this->options);

$key = array_key_last($this->options);

$newPosition = (int) array_key_last($escalations) + 1;

@yhabteab yhabteab changed the title Don't use features only available sind PHP 7.3 Don't use features only available since PHP 7.3 Sep 25, 2023
@nilmerg
Copy link
Member

nilmerg commented Sep 26, 2023

Or we consider changing the minimum requirement. To my knowledge, no distribution we support still uses PHP 7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants