Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve consistent build failures due to listen port #137

Open
Ianleeclark opened this issue Aug 24, 2016 · 1 comment
Open

Resolve consistent build failures due to listen port #137

Ianleeclark opened this issue Aug 24, 2016 · 1 comment

Comments

@Ianleeclark
Copy link
Owner

Right now whenever unit tests are ran, there's a high likelihood of at least one of the (6 total) tests failing, due to a port already being listened on. This is pretty agitating, having to continually run the tests, so I need to figure out a better way of running tests/choosing a port.

@Ianleeclark
Copy link
Owner Author

Randomized ports are one thing, but I either have to rely on the travis CI config or check, at boot time, if we're in a test environment--this still relies on travis.

Ianleeclark pushed a commit that referenced this issue Aug 25, 2016
REMOVE:
  - network/network_handler_test.go: A temporary measure has been put into
    place where we're skipping starting the network handlers. Essentially this
    means we're no longer testing, but testing **will** be resumed once a
    better testing system has been decided.
Ianleeclark pushed a commit that referenced this issue Aug 25, 2016
CHANGE:
  - network/network_handler_test.go Rookie mistakes causing build failures.
    Extra imports, so I just commented everything out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant